MAINT: dropping python3.8 support #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Nov 26, 2024
pllim
reviewed
Nov 26, 2024
| @@ -314,7 +314,7 @@ def test_normalize_with_ellipsis(self): | |||
| c = OutputChecker() | |||
| got = [] | |||
| for char in ['A', 'B', 'C', 'D', 'E']: | |||
| got.append('%s %s' % (char, float(ord(char)))) | |||
| got.append('{} {}'.format(char, float(ord(char)))) | |||
There was a problem hiding this comment.
Automated mess I guess 🤷♀️
I mean, I pushed stuff before boarding a flight, but as I said above there is some weird stuff happening locally already so I'll very likely have to follow up with more manual fixes
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some issues locally when running the tests, please don't merge this just yet even if CI is all green, so I can ensure that it's indeed just a local issue (I don't see it with tox, but do see it when running tests directly in the source)