ENH: adding doctest-requires-all directive #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jan 23, 2025
README.rst
Outdated
| @@ -336,6 +336,11 @@ the package's ``setup.cfg`` file. The syntax for this option is a list of | |||
|
|
|||
| Multiple requirements can be specified if separated by semicolons. | |||
|
|
|||
|
|
|||
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
bsipocz
force-pushed
the
doctest-requires-all
branch
from
0044a42 to
74cebb8
Compare
pllim
reviewed
Jan 23, 2025
Comment on lines
+453
to
+455
| This is a narrative line, before another doctest snippet | ||
|
|
||
| >>> import foobar |
There was a problem hiding this comment.
Fix formatting to reflect typical real use case.
Suggested change
| This is a narrative line, before another doctest snippet | |
| >>> import foobar | |
| This is a narrative line, before another doctest snippet:: | |
| >>> import foobar |
There was a problem hiding this comment.
This should not matter, all the snippets should be collected no matter if there are :: or correct number of spaces before the >>>.
|
I go ahead and merge this now, so the other PR doesn't have to be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need for this came up again recently in astroquery, so finally I got down to do it.
To close #183