-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change/Fix: Include "theme-css/*.scss" files #429
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Note the review comment on |
See <scientific-python#429 (comment)>. Suggested-by: Stefan van der Walt <stefanv@berkeley.edu>
@stefanv Thanks, I applied that glob pattern to all the relevant places in this file. |
8148480
to
580386a
Compare
Is this causing the "Undefined mixin" errors from TOCSS-DART?
@stefanv Using the #418 is waiting on this to be merged, so if you'd like me to look into the issues with that glob pattern, I could do that in a separate issue. |
{{ if $inServerMode -}} | ||
{{ $custom_style := . | resources.ExecuteAsTemplate . $page -}} | ||
<link rel="stylesheet" href="{{ $custom_style.RelPermalink }}"> | ||
{{ else }} | ||
{{ $custom_style := . | resources.ExecuteAsTemplate . $page | minify | fingerprint -}} | ||
<link rel="stylesheet" href="{{ $custom_style.RelPermalink }}" integrity="{{ $custom_style.Data.Integrity }}"> | ||
{{- end -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this indentation is because of the generated HTML—with this change, the generated file with have spaces before the <link>
tags.
I'm OK with keeping it as-is, but my emacs also doesn't indent that way by default.
Perhaps you have settings I can adopt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indented these lines manually for clarity in the source code (the {{- end -}}
repeated 3 lines in a row, with different opening lines for each block, is hard to follow). But just let me know how you want this to be done.
It probably means that we should only load top-level PDST SCSS, which then itself imports deeper down. |
Ok, shall we handle changing the glob patterns in a separate issue then? It also seems like a bit of a design or policy decision, whether to use or allow subdirectories for downstream stylesheet files. |
Thanks, let's get this in so the copy button PR can be rebased. |
This includes Sass files in the
theme-css
directory (previously they were only included from the downstreamcss
directory).To be used in #418.