Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor font loading #597

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented May 3, 2024

We now only provide a mechanism for loading fonts from Google. To set a font, the user needs to provide custom CSS. The documentation gives an example.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3f787e5
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/663523ab09af190008406c5d
😎 Deploy Preview https://deploy-preview-597--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

We now only provide a mechanism for *loading* fonts from Google.
To *set* a font, the user needs to provide custom CSS.
The documentation gives an example.
@stefanv stefanv added the type: Enhancement New feature or request label May 3, 2024
@jarrodmillman jarrodmillman marked this pull request as draft May 3, 2024 17:34
@jarrodmillman jarrodmillman marked this pull request as ready for review May 3, 2024 18:13
@jarrodmillman jarrodmillman merged commit fa5570b into scientific-python:main May 3, 2024
6 checks passed
@jarrodmillman jarrodmillman added this to the 0.18 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants