Skip to content

Commit

Permalink
Use codespell (#259)
Browse files Browse the repository at this point in the history
  • Loading branch information
jarrodmillman authored Aug 2, 2023
1 parent ecb4d92 commit d0f436a
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ repos:
- id: pyupgrade
args: [--py38-plus]

- repo: https://github.com/codespell-project/codespell
rev: "355e50e14fd03fe83e4ed9aa0489824b150b3b58" # frozen: v2.2.5
hooks:
- id: codespell

ci:
autofix_prs: false
autofix_commit_msg: "[pre-commit.ci 🤖] Apply code format tools to PR"
Expand Down
6 changes: 3 additions & 3 deletions .tools/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def prompt(
Parameters
----------
prompt_text : str
Text displayed when promting user for input.
Text displayed when prompting user for input.
validate : callable, f(val)
Called to validate the input. If this function raises or
returns None, try again.
Expand Down Expand Up @@ -36,7 +36,7 @@ def valid(s):
return value

default_flag = f" [{default}]" if default is not None else ""
while (ans := valid(input(f"{prompt_text}{default_flag}: "))) is None:
while (answer := valid(input(f"{prompt_text}{default_flag}: "))) is None:
pass

return ans
return answer
2 changes: 1 addition & 1 deletion spec-0003/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ While the recommendations provided here cover important aspects of accessibility
- The [Web Content Accessibility Guidelines (W3C)](https://www.w3.org/TR/WCAG/) provide a comprehensive set of international standards for enhancing web content accessibility.
- The [comprehensive checklist](https://www.a11yproject.com/checklist/) published by the A11y organization offers a user-friendly description of the W3C's accessibility standards.
- The [Numfocus Discover Cookbook](https://discover-cookbook.numfocus.org/intro.html) is a valuable resource for understanding event/meeting accessibility and implementing inclusive practices.
- The [Accesibility Insights YouTube channel](https://www.youtube.com/@AccessibilityInsights) provides tutorials on using Accessibility Insights tools to test and improve website accessibility.
- The [Accessibility Insights YouTube channel](https://www.youtube.com/@AccessibilityInsights) provides tutorials on using Accessibility Insights tools to test and improve website accessibility.
- The articles available on the The [axxeslab Articles website](https://axesslab.com/articles/) offer helpful information about accessibility and testing.

## Submit your feedback
Expand Down
6 changes: 3 additions & 3 deletions spec-0004/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,14 @@ The site admins are drawn from active members from the scientific Python communi
Ideally, the collection of admins comprises a broad selection of community
members across different projects and underlying organizations.
This is to ensure community ownership of the wheel-hosting infrastructure and
adminstration governed by consensus, as opposed to unilateral
administration governed by consensus, as opposed to unilateral
decision-making by any individual, project, or organization.
Adding new administrators requires at least an issue to be opened.
After a project creates an issue on https://github.com/scientific-python/upload-nightly-action
requesting access to upload wheels a admin has to respond to that request.

We want to be open to projects uploading wheels but at the same time need to perform some
amount of due dilligence before giving people access. This is because once a project is given
amount of due diligence before giving people access. This is because once a project is given
access their work will be broadcasted through the broad exposure of Scientific Python. This
could be abused to publish malicious packages.

Expand All @@ -129,7 +129,7 @@ The creation of tokens at the organization level should be avoided for security

Then you need to do a first upload of a wheel to create the package listing on anaconda.org.
Once this operation is done, you can revoke your token and add the new user to its project.
For a given project, at leat one user should be admin of that project.
For a given project, at least one user should be admin of that project.

At that point, let the user know that they have been added and that they can create a personal
access token (as outlined above.) They can now upload new wheels and perform maitenance
Expand Down

0 comments on commit d0f436a

Please sign in to comment.