Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure draft accessibility SPEC #134

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

isabela-pf
Copy link
Contributor

@MarsBarLee and I have been trying to sort out a way to handle the work and scope of this draft SPEC based on the knowledge and time we have to offer. This PR restructures the SPEC to include sub topics.

This version of the draft SPEC allows for the broad "accessibility" topic while also giving us room to contribute image description information specifically. We hope this is a solid compromise that leaves this project lots of room to grow if desired.

Some of the content removed in this PR will be moved to accessibility.scientific-python.org. If it helps, you can see progress on our working PR for the website.

References discussion on scientific-python/accessibility.scientific-python.org #4.

Let me know if you have any questions or see any errors. Thanks in advance for any review! 🌻

@isabela-pf
Copy link
Contributor Author

Hi there! I'm sure it's my mistake, but I'm not sure how to fix the code formatting so the test pass. Does anyone have docs I should look at (or want to fix it)?

@jarrodmillman
Copy link
Member

I will take a look at it later today. I need to update a few things and I will add some text about how to run the auto-formatter, which isn't stated anywhere at the moment.

@isabela-pf
Copy link
Contributor Author

Just wanted to check in if there's any changes I need to make on this. Let me know if there's anything I can do to help!

@isabela-pf
Copy link
Contributor Author

I'm being the squeaky wheel! Please let me know if I can take any actions to help out.

@isabela-pf
Copy link
Contributor Author

One more ping on this to see if I can help. While there's not a deadline, I'd rather have an accurate and up-to-date representation of the SPEC up so I'm happy to make whatever changes are needed.

@isabela-pf
Copy link
Contributor Author

Giving this another nudge for feedback or anything I'm missing! Please let me know what I can do to move this forward.

@isabela-pf
Copy link
Contributor Author

Hi again! Is there any update on something I can do to fix the formatting error? The test logs no longer exist so I may push something to get the tests running again.

@jarrodmillman jarrodmillman merged commit 19cac50 into scientific-python:main Sep 5, 2022
@isabela-pf
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants