Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Create PR on main website when SPEC repo is updated #248

Closed

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Jul 18, 2023

See scientific-python/scientific-python.org#408

The purpose of this PR is to autogenerate PRs for https://github.com/scientific-python/scientific-python.org to update the SPEC submodule when changes appear on main. I am trying to follow the instructions found here:

It says you need a "a repo scoped Personal Access Token (PAT) ," but I am using a "Fine-grained personal access tokens" with " Read and Write access to pull requests" to "scientific-python/scientific-python.org".

I haven't used peter-evans/create-pull-request before and would love detailed feedback or suggestions on this.

@jarrodmillman jarrodmillman marked this pull request as draft July 18, 2023 18:53
@jarrodmillman jarrodmillman changed the title Create PR on main website when SPEC repo is updated WIP: Create PR on main website when SPEC repo is updated Jul 18, 2023
@bsipocz
Copy link
Member

bsipocz commented Jul 18, 2023

I wonder whether dependabot could be used for this, too rather than a new thing? afaik it can handle git submodule updates, too, and we already use it.

@jarrodmillman
Copy link
Member Author

jarrodmillman commented Jul 18, 2023

I wonder whether dependabot could be used for this, too rather than a new thing? afaik it can handle git submodule updates, too, and we already use it.

I was considering that as well. If we do that I think we need to use a cron job to check whether this repo has been updated. I thought it made more sense to make a PR whenever we updated this repo instead. But I don't have a strong opinion. If we use dependabot on the "scientific-python/scientific-python.org" repo, I suppose we should do it everyday (see scientific-python/scientific-python.org#448).

Thoughts? @bsipocz @stefanv @pllim @henryiii @tupui

@jarrodmillman
Copy link
Member Author

Closing as we preferred this approach: scientific-python/scientific-python.org#448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants