Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Commit

Permalink
Bumping hyrax to address silent infinite retries
Browse files Browse the repository at this point in the history
From the Bulkrax pull request:

> Prior to this commit, when we encountered a
> `Bulkrax::CollectionsCreatedError`, we would reschedule the same job
> with a 1 minute delay.  However, if the underlying issue was never
> resolved, we would continually reschedule without fanfare this failing
> job.
>
> With this commit, we provide 3 logged reschedules, then if that fails
> we raise an exception break the infinite cycle.  By breaking the
> cycle, then the upstream Sidekiq handler can determine if it should be
> thrown into the `Retry` queue (where the jobs that raise exceptions
> go).
>
> We discovered this in Adventist watch 100 or scheduled jobs run very
> fast, and apparently continually rescheduling themselves.

Related to:

- samvera/bulkrax#692
- samvera/bulkrax#691
  • Loading branch information
jeremyf committed Dec 19, 2022
1 parent 94a7ed4 commit aa3ef05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ end

# Bulkrax
group :bulkrax do
# Until f48623384d312db4758a36a4dff61dca2e609119 is in a major release, use this ref or a ref
# Until d36cf3606545ea30da8d8082f1b67b96d9aaf8c1 is in a major release, use this ref or a ref
# who's ancestors include this ref.
# rubocop:disable Metrics/LineLength
gem 'bulkrax', "~> 4.4", git: "https://github.com/samvera-labs/bulkrax.git", ref: "f48623384d312db4758a36a4dff61dca2e609119"
gem 'bulkrax', "~> 4.4", git: "https://github.com/samvera-labs/bulkrax.git", ref: "d36cf3606545ea30da8d8082f1b67b96d9aaf8c1"
# rubocop:enable Metrics/LineLength
gem 'willow_sword', git: 'https://github.com/notch8/willow_sword.git'
end
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ GIT

GIT
remote: https://github.com/samvera-labs/bulkrax.git
revision: f48623384d312db4758a36a4dff61dca2e609119
ref: f48623384d312db4758a36a4dff61dca2e609119
revision: d36cf3606545ea30da8d8082f1b67b96d9aaf8c1
ref: d36cf3606545ea30da8d8082f1b67b96d9aaf8c1
specs:
bulkrax (4.4.0)
bagit (~> 0.4)
Expand Down

0 comments on commit aa3ef05

Please sign in to comment.