Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Bumping hyrax to address silent infinite retries #210

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Dec 19, 2022

From the Bulkrax pull request:

Prior to this commit, when we encountered a
Bulkrax::CollectionsCreatedError, we would reschedule the same job
with a 1 minute delay. However, if the underlying issue was never
resolved, we would continually reschedule without fanfare this failing
job.

With this commit, we provide 3 logged reschedules, then if that fails
we raise an exception break the infinite cycle. By breaking the
cycle, then the upstream Sidekiq handler can determine if it should be
thrown into the Retry queue (where the jobs that raise exceptions
go).

We discovered this in Adventist watch 100 or scheduled jobs run very
fast, and apparently continually rescheduling themselves.

Related to:

From the Bulkrax pull request:

> Prior to this commit, when we encountered a
> `Bulkrax::CollectionsCreatedError`, we would reschedule the same job
> with a 1 minute delay.  However, if the underlying issue was never
> resolved, we would continually reschedule without fanfare this failing
> job.
>
> With this commit, we provide 3 logged reschedules, then if that fails
> we raise an exception break the infinite cycle.  By breaking the
> cycle, then the upstream Sidekiq handler can determine if it should be
> thrown into the `Retry` queue (where the jobs that raise exceptions
> go).
>
> We discovered this in Adventist watch 100 or scheduled jobs run very
> fast, and apparently continually rescheduling themselves.

Related to:

- samvera/bulkrax#692
- samvera/bulkrax#691
@jeremyf jeremyf merged commit f47d53f into main Dec 21, 2022
@jeremyf jeremyf deleted the jeremyf---bumping-bulkrax branch December 21, 2022 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants