Skip to content

Commit

Permalink
Clean up metadata issues (#834)
Browse files Browse the repository at this point in the history
# Story

Metadata yaml files were audited and edited to:
- Change dates to be single rather than multiple
- Add multiple: false on form when term is not multiple... form defaults
to multiple and term defaults to singular.
- Remove unnecessary state & arkivo_checksum
- remove dc_access_rights, which shares the same predicate in fedora
with access_rights. (the shared predicate means they do the same thing,
and the term is not accessed except in indexing.)

Refs

- #777
- #822

# Expected Behavior Before Changes

Many works types could be created but not edited.
Metadata single or multiple on form did not match production.

# Expected Behavior After Changes

- All work types and collection can be created.
- All work types and collection can be edited.
- All fields [with the exception of based_near location
dropdown](#212)
can be used.

# Screenshots / Video

<details>
<summary></summary>

**All work types and collection were tested, and can be both created and
edited.**

![Screenshot 2024-09-30 at 4 09
38 PM](https://github.com/user-attachments/assets/69cd75bc-7323-48e6-9a16-a17b6f6eab56)

</details>

# Notes

OER and ETD do not currently work. These come in via Hyku and are not
used in Adventist, so they have not been adequately set up. At this
point, they should be deactivated in all tenants to avoid any potential
issues.
  • Loading branch information
laritakr authored Sep 30, 2024
2 parents 5b79bcd + 722dd37 commit 655254f
Show file tree
Hide file tree
Showing 10 changed files with 90 additions and 100 deletions.
29 changes: 14 additions & 15 deletions config/metadata/adl_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ attributes:
multiple: false
form:
primary: false
multiple: false
index_keys:
- preflabel_tesi
- preflabel_si
Expand All @@ -83,6 +84,7 @@ attributes:
multiple: false
form:
primary: false
multiple: false
index_keys:
- rdfs_label_tesi
predicate: http://www.w3.org/2000/01/rdf-schema#label
Expand All @@ -92,6 +94,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- date_tesim
- date_sim
Expand Down Expand Up @@ -149,21 +152,17 @@ attributes:
- "access_right_tesim"
predicate: http://purl.org/dc/terms/accessRights
# slugs previously used same predicate
# @TODO: removing index keys for now, until slug remediation script is complete.
alternative_title:
type: string
multiple: true
form:
primary: false
index_keys:
- "alternative_title_sim"
- "alternative_title_tesim"
display: false
# index_keys:
# - "alternative_title_sim"
# - "alternative_title_tesim"
predicate: http://purl.org/dc/terms/alternative
arkivo_checksum:
type: string
multiple: false
form:
primary: false
predicate: http://scholarsphere.psu.edu/ns#arkivoChecksum
based_near:
type: string
multiple: true
Expand Down Expand Up @@ -206,6 +205,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- "date_created_sim"
- "date_created_tesim"
Expand Down Expand Up @@ -252,8 +252,10 @@ attributes:
predicate: http://purl.org/dc/elements/1.1/publisher
label:
type: string
multiple: false
form:
primary: false
multiple: false
index_keys:
- "label_sim"
- "label_tesim"
Expand Down Expand Up @@ -365,26 +367,23 @@ attributes:
multiple: false
form:
primary: false
multiple: false
predicate: http://opaquenamespace.org/ns/hydra/owner
on_behalf_of:
type: string
multiple: false
form:
primary: false
multiple: false
index_keys:
- on_behalf_of_ssi
predicate: http://scholarsphere.psu.edu/ns#onBehalfOf
state:
type: string
multiple: false
form:
primary: false
predicate: http://fedora.info/definitions/1/0/access/ObjState#objState
proxy_depositor:
type: string
multiple: false
form:
primary: false
multiple: false
index_keys:
- proxy_depositor_ssi
predicate: http://scholarsphere.psu.edu/ns#proxyDepositor
33 changes: 14 additions & 19 deletions config/metadata/collection_resource.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- date_tesim
- date_sim
Expand All @@ -24,7 +25,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_available_tesim
- date_available_sim
Expand All @@ -34,7 +35,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_published_tesim
- date_published_sim
Expand All @@ -44,7 +45,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_submitted_tesim
- date_submitted_sim
Expand All @@ -54,7 +55,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_accepted_tesim
- date_accepted_sim
Expand All @@ -64,7 +65,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_issued_tesim
- date_issued_sim
Expand Down Expand Up @@ -108,7 +109,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- issue_number_tesim
predicate: http://schema.org/issueNumber
Expand Down Expand Up @@ -168,6 +169,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- pagination_tesim
predicate: http://schema.org/pagination
Expand Down Expand Up @@ -236,6 +238,7 @@ attributes:
multiple: false
form:
primary: false
multiple: false
index_keys:
- preflabel_tesi
- preflabel_si
Expand All @@ -253,6 +256,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- volume_number_tesim
predicate: http://schema.org/volumeNumber
Expand All @@ -275,7 +279,6 @@ attributes:
- "access_right_sim"
- "access_right_tesim"
predicate: http://purl.org/dc/terms/accessRights
# slugs previously used same predicate
alternative_title:
type: string
multiple: true
Expand All @@ -285,12 +288,6 @@ attributes:
- "alternative_title_sim"
- "alternative_title_tesim"
predicate: http://purl.org/dc/terms/alternative
arkivo_checksum:
type: string
multiple: false
form:
primary: false
predicate: http://scholarsphere.psu.edu/ns#arkivoChecksum
based_near:
type: string
multiple: true
Expand Down Expand Up @@ -333,6 +330,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- "date_created_sim"
- "date_created_tesim"
Expand Down Expand Up @@ -492,26 +490,23 @@ attributes:
multiple: false
form:
primary: false
multiple: false
predicate: http://opaquenamespace.org/ns/hydra/owner
on_behalf_of:
type: string
multiple: false
form:
primary: false
multiple: false
index_keys:
- on_behalf_of_ssi
predicate: http://scholarsphere.psu.edu/ns#onBehalfOf
state:
type: string
multiple: false
form:
primary: false
predicate: http://fedora.info/definitions/1/0/access/ObjState#objState
proxy_depositor:
type: string
multiple: false
form:
primary: false
multiple: false
index_keys:
- proxy_depositor_ssi
predicate: http://scholarsphere.psu.edu/ns#proxyDepositor
11 changes: 6 additions & 5 deletions config/metadata/conference_item_resource.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_published_tesim
- date_published_sim
Expand All @@ -46,7 +46,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_available_tesim
- date_available_sim
Expand All @@ -56,7 +56,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_submitted_tesim
- date_submitted_sim
Expand All @@ -66,7 +66,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- date_accepted_tesim
- date_accepted_sim
Expand All @@ -85,7 +85,7 @@ attributes:
multiple: true
form:
primary: false
multiple: true
multiple: false
index_keys:
- event_date_tesim
- event_date_sim
Expand All @@ -111,6 +111,7 @@ attributes:
multiple: true
form:
primary: false
multiple: false
index_keys:
- pagination_tesim
predicate: http://schema.org/pagination
Expand Down
Loading

0 comments on commit 655254f

Please sign in to comment.