Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_work_attributes_function should call Array.wrap not to_a #729

Open
2 tasks
Tracked by #725
laritakr opened this issue Aug 5, 2024 · 0 comments
Open
2 tasks
Tracked by #725

child_work_attributes_function should call Array.wrap not to_a #729

laritakr opened this issue Aug 5, 2024 · 0 comments
Assignees
@laritakr
Labels
contribute back code needs to be contributed to open source good first issue IiifPrint M3 Milestone 3 tech debt Valkyrie
Milestone
Milestone 3 - com...

Comments

@laritakr
Copy link
Contributor

laritakr commented Aug 5, 2024 •
edited by ShanaLMoore
Loading

Story

IiifPrint's child_work_attribute_function uses to_a when it should use Array.wrap(). Replace this default config and then remove the custom config in adventist_knapsack.

This ticket is to contribute back work to...(see @laritakr for details).

Acceptance Criteria

  • Update child_work_attribute_function in IiifPrint
  • Remove custom function in adventist_knapsack's config

Screenshots / Video

Testing Instructions and Sample Files
@laritakr laritakr mentioned this issue Aug 5, 2024
Closed
4 tasks
laritakr added a commit that referenced this issue Aug 5, 2024
@laritakr
Override IiifPrint
c88e0b7 
Temporary patches until the changes are pushed into IiifPrint.

See #728
and child_work_attributes_function should call Array.wrap not to_a #729
@laritakr laritakr added the contribute back code needs to be contributed to open source label Aug 23, 2024
@ShanaLMoore ShanaLMoore added the M3 Milestone 3 label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
contribute back code needs to be contributed to open source good first issue IiifPrint M3 Milestone 3 tech debt Valkyrie
Projects
Adventist Knapsack
Status: No status
Milestone
Milestone 3 - completion of project
Development

No branches or pull requests
3 participants
@ShanaLMoore @laritakr @jillpe