Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bulkrax related_url CSV import doesn't work on staging #746

Open
1 task
ShanaLMoore opened this issue Aug 14, 2024 · 5 comments
Open
1 task

🐛 Bulkrax related_url CSV import doesn't work on staging #746

ShanaLMoore opened this issue Aug 14, 2024 · 5 comments
Assignees

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Aug 14, 2024

Summary

Unable to import works with related urls.

Steps to reproduce:

Create a CSV importer for the sample file

Acceptance Criteria

  • A user should be able to import remote_files (aka related_urls) in a csv format

Screenshots or Video

Image

Testing Instructions

Notes

@ShanaLMoore
Copy link
Contributor Author

@ShanaLMoore ShanaLMoore changed the title 🐛 no superclass method `to_solr' for #<Hyrax::FileSetIndexer 🐛 Bulkrax CSV and OAI import don't work on staging Aug 14, 2024
@laritakr laritakr self-assigned this Aug 15, 2024
laritakr added a commit that referenced this issue Aug 20, 2024
# Story

Update submodule to bring in admin set fix and bulkrax fix.

Refs 
- #755
and #746

# Expected Behavior Before Changes

- Admin set edit failed
- Imports using unmigrated admin sets failed

# Expected Behavior After Changes

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@ShanaLMoore ShanaLMoore changed the title 🐛 Bulkrax CSV and OAI import don't work on staging 🐛 Bulkrax related_url CSV import doesn't work on staging Aug 26, 2024
@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Aug 26, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 26, 2024

QA RESULTS: ❌

tested on STAGING

sample file: basic-advnetist-related-urls-import(1).csv

something seems wrong. I imported the csv but don't see any updates or evidence that any works got created.

status says pending

I didn't see any import work jobs run in good jobs. I restarted the workers and tried to re run it again. No errors are being displayed.

Image

Image

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 27, 2024

Reporting back.

I checked on this again the following day and it seems like I wasn't patient enough the first time. The jobs must've still been enqueue and backlogged. Alas, the importer still failed even though I see works got created.

Image

Image

Image

@laritakr
Copy link
Contributor

The problem here is 1) the workers were severely backlogged yesterday (nothing in default queue was going through until overnight) and 2) the CSV has a bad url.

I corrected the CSV and resubmitted your importer: https://demo.s2.adventistdigitallibrary.org/importers/39?locale=en
I corrected the CSV, submitted a new import it worked for me. https://demo.s2.adventistdigitallibrary.org/importers/40?locale=en

Both succeeded.

@laritakr laritakr removed the needs rework issue needs additional work label Aug 27, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 27, 2024

This looks good to me too. Thanks for clarifying! However, one of them has a pdf and it didn't split. Should it have? I'll make a separate ticket

QA RESULTS: ✅ PASS

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants