Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie: Catalog search display discrepancies #759

Open
KatharineV opened this issue Aug 20, 2024 · 3 comments
Open

Valkyrie: Catalog search display discrepancies #759

KatharineV opened this issue Aug 20, 2024 · 3 comments

Comments

@KatharineV
Copy link
Collaborator

This ticket will compare and contrast ADL production with staging (post version 6 and Valkyrie). We'd like to bring parity back to most displays and features. If there is something that is not important that I see is different, I won't track it here. Everything listed below is important enough to merit an attempt to reconcile and bring staging up to match.

Catalog search

  1. Image work type

Production

Image

Staging

Image

Differences to reconcile:

  • Staging title is a hyperlink but displays as black font and is not clearly clickable until you mouse over it. We'd like it to display with hyperlink color font, as production shows.
  • Creator field is blank and therefore should not display in the catalog or the work (see additional ticket about Image work type discrepancies to note that blank creator/author field is showing in both places)
  • Staging subjects are not clickable links in the catalog search, and they should be clickable as in production.
  1. Published Work work type

Production

Image

Staging

Image

Differences to reconcile:

  • Creator field reads as "author" on production. On staging, it reads as "author" on the work page. It is only showing "Creator" in the catalog search, which is not ideal because it fails to match the customized label as it appears elsewhere. We'd like to have the field label the same between catalog search and work page. I don't think it matters so much which label is the final one, it just needs to match.
  • Creator/author name is a hyperlink on production and not clickable on staging. Clickable needs to be present.
@ShanaLMoore ShanaLMoore added the M1 Milestone 1 label Sep 3, 2024
@AKFosterDev AKFosterDev self-assigned this Sep 6, 2024
@K8Sewell K8Sewell self-assigned this Sep 13, 2024
@K8Sewell
Copy link
Contributor

Engineering Note

Looks like the issue is that in hyrax the index fields in the catalog controller have a helper called ‘link)to)search’ and this helper is not present in Yale’s catalog controller and may be the cause of facetable metadata fields not being clickable on the index page. There is an extra complication in that in Adventist’s catalog controller the index fields are overwritten with properties from dog biscuits from the property mapping config.

kirkkwang added a commit that referenced this issue Sep 23, 2024
This commit will update the deprecated link_to_search to link_to_facet
which will enable the faceted properties on each search hit to be a
link.

Ref:
- #759
kirkkwang added a commit that referenced this issue Sep 23, 2024
This commit will update the deprecated link_to_search to link_to_facet
which will enable the faceted properties on each search hit to be a
link.

Ref:
- #759
kirkkwang added a commit that referenced this issue Sep 23, 2024
This commit will update the deprecated link_to_search to link_to_facet
which will enable the faceted properties on each search hit to be a
link.

Ref:
- #759
kirkkwang added a commit that referenced this issue Sep 23, 2024
# Story

This commit will update the deprecated link_to_search to link_to_facet
which will enable the faceted properties on each search hit to be a
link.

Ref:
- #759

# Screenshots / Video
<img width="1274" alt="image"
src="https://github.com/user-attachments/assets/8e1f13d5-8df3-4f77-b1a3-444658e6eca4">
@kirkkwang
Copy link
Contributor

✅ Facets show up now, link looks like a link, still says Author

Image

@KatharineV
Copy link
Collaborator Author

All appears to be working as expected in staging now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Deploy to Production
Development

No branches or pull requests

6 participants