Load view paths on display #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
test-view-paths
branch
from
5c516bf
to
a42c7a2
Compare
jeremyf
force-pushed
the
test-view-paths
branch
from
a42c7a2
to
69e6acc
Compare
ShanaLMoore
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are discovering that view paths are not consistent across different controllers. Prior to this PR, for some of the controllers, we had a view path of:
/app/samvera/app/views//app/samvera/hyrax-webapp/app/views/And for others, in particularly the Works controllers, we had:
/app/samvera/hyrax-webapp/app/views//app/samvera/app/views/With this commit, we're taking a hammer to the view paths to mash them into shape.