🧹 Rename image_form_spec to reflect decoration #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the Knapsace image_form_spec had a test for terms
that was not part of the Hyku. We introduce these differences through our
decoration in ./app/forms/hyrax/image_form_decorator.rb
To reflect the existence of the decorator and not have a duplicate file
that future us would need to synchronize with Hyku, I've moved the file
and winnowed it down to reflect the specific changes.
I also needed to add three new properties to the spec as it reflects
upstream changes in Hyku (e.g.
access_right
alternative_title
rights_notes
)Diff of filein Hyku and Knapsack
Related to: