Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Hide User Collection and Public tags #795

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sjproctor
Copy link
Contributor

Story

🎁 Hide User Collection and Public tags

This commit hides the User Collection and Public tags from the public
collection show pages (admin dashbaord) and the catalog search results
page.

Ref:

Expected Behavior Before Changes

  • User Collection and Public tags were visible on the collection show page
Screenshot 2024-09-09 at 1 19 24 PM
  • User Collection and Public tags were visible on the catalog search results
Screenshot 2024-09-09 at 2 04 21 PM

Expected Behavior After Changes

  • User collection and Public tags are not visible on the collection show page
Screenshot 2024-09-09 at 1 55 02 PM
  • User Collection and Public tags are not visible on the catalog search results
Screenshot 2024-09-09 at 1 59 36 PM

Notes

The acceptance criteria was updated to include the Public tags as well as the User Collection tags. Approved by Katharine in Slack.

This commit hides the User Collection and Public tags from the public
collection show pages (admin dashbaord) and the catalog search results
page.

Ref:
- #791
@sjproctor sjproctor merged commit 845eaad into pull-in-hyku-knapsack Sep 9, 2024
6 checks passed
@sjproctor sjproctor deleted the hide-user-collection-tag branch September 9, 2024 23:24
sjproctor added a commit that referenced this pull request Sep 10, 2024
# Story

🎁 Hide User Collection and Public tags

This commit expands on #795 to hides all tags from collection and works
show pages. Additional tags were found in staging that will be removed
by this commit.

Ref:
- #791

# Expected Behavior Before Changes

- `User Collection` and `Public` tags were visible on collection and
works show pages

# Expected Behavior After Changes

- No `User collection` or `Public` are visible

# Notes

The acceptance criteria is to match parity with the production
application. There were additional tags found in staging that were
removed by this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants