Update good_job command in docker-compose.yml #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodJob should run when jobs are triggered. This commit start up the container automatically when we docker-compose up. Before this change it was trying to start sidekiq since that's what hyrax-webapp's docker-compose.yml does. Issue - https://github.com/scientist-softserv/adventist-dl/issues/571
ShanaLMoore
changed the base branch from
main
to
i564-create-various-work-types
AttachFilesToWorkJob was failing because we forgot to bring over some methods from adventist.
We were receiving an error: "ActiveTriples::UndefinedPropertyError (The property 'override_default_thumbnail' is not defined on class 'FileSet::GeneratedResourceSchema');
ShanaLMoore
changed the title
For the sake of organization and relevancy, I removed these commits and will create a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated docker-compose.yml so that it knows to boot up good_job or sidekiq on docker-compose up.