Remove Custom Mediated Deposit Workflow from options for Workflows on admin sets

[crisr15]

Summary

Currently there are two options for mediated deposit in Palni/Palci, but both function the same. This is confusing for users and they should only have one options. Remove the Custom Mediated Depot Workflow for Hyku Commons from the options and leave only the one step mediated deposit workflow and default workflow.

Acceptance Criteria

• Write a script to migrate all Admin sets on the Custom Mediated Deposit Workflow for Hyku Commons to the One-Step mediated deposit workflow. This script needs to run across all tenants.
• Change the default for an admin set to be "One-step mediated deposit workflow"
• Remove the Custom Mediated Deposit Workflow for Hyku Commons from the options on the Admin Set Workflow Page

Testing Instructions

• check that admin sets previusly set to teh Custom Mediated Deposit Workflow for Hyku Commons are now set to One-Step Mediated deposit. Sample admin set in staging: https://dev.commons-archive.org/admin/admin_sets/b5c672a7-353e-42cf-a63e-b214cfbea9e5?locale=en
• Create a new Admin set. Confirm that the workflow is automatically set to One-Step Mediated deposit workflow.
• On the workflow page of your new admin set confirm that there is not an option to pick the Custom Mediated Deposit Workflow for hyku commons.

Notes

[aprilrieger]

The script has already been run on staging and production to reassign the workflow 'hyku_commons_mediated_deposit' to 'one_step_mediated_deposit'.

[labradford]

Client reports that new works that are deposited into the new default workflow are not showing up on the Review Submissions tab

[labradford]

From Nic

Newly deposited works not being added to the approval queue. Newly deposited work (https://nic2.commons-archive.org/concern/generic_works/dccec165-2513-4dd8-8213-b8bc1887c4aa?locale=en) shows "pending approval" status but the approval ribbon doesn't appear. Admin set currently using "one-step mediated deposit," though the "custom" workflow still appears as an option.

[labradford]

from Nic

In some repositories this change is working, in others (https://au-archives.hykucommons.org/admin/workflows?locale=en) I submitted a test work in an admin set with mediated deposit, and the queue shows "no data available in table" and depositors in the already published tab are still pulling from creator. Possibly related to #448 ?

[labradford]

Did some research which led me to Hyrax app/services/hyrax/workflow/actionable_objects.rb but did not get further into my research to figure out if the problem is in this file.

[summer-cook]

Have been investigating this

NOTES:

when creating a test work with the One-Step Mediated deposit workflow it DOES appear in the notifications:

But does not appear in the "Review Submissions" tab/queue

[summer-cook]

This is not a problem for me in dev - the submission shows up normally. Possibly changes have not yet made it to prod?

[crisr15]

@ndroark After doing some research we dont think this ticket is related to the work we did. And while looking at the other workflow error you were reporting with the 500 errors, I did some research on what was going on with the newest version of hyrax. That led me down a long path to this issue that was just added to the newest version of hyrax: samvera/hyrax#5933. The solution for that seems like it may have broken our pagination in hyku, but that change accidentally got pulled into prod when we did the analytics upgrade. All of this is to say that the team is still working on this, but that its an isolated issue from the work we did on the workflow sprint. We may want to close this ticket and track changes on the new error ticket you made.

[laritakr]

@ndroark After doing some research we dont think this ticket is related to the work we did. And while looking at the other workflow error you were reporting with the 500 errors, I did some research on what was going on with the newest version of hyrax. That led me down a long path to this issue that was just added to the newest version of hyrax: samvera/hyrax#5933. The solution for that seems like it may have broken our pagination in hyku, but that change accidentally got pulled into prod when we did the analytics upgrade. All of this is to say that the team is still working on this, but that its an isolated issue from the work we did on the workflow sprint. We may want to close this ticket and track changes on the new error ticket you made.

This message seems to imply that there is another error ticket, and that this ticket was intended to be closed?

It appears that we need a clear list of exactly what we need to accomplish, as this ticket has so many conversations that it is unclear.

[ndroark]

We had done work previously so that new tenants are created with just the two workflows. Some older tenants still have three (example: https://butler.hykucommons.org/admin/admin_sets/admin_set%2Fdefault/edit?locale=en#workflow). Acceptance criteria for this ticket would be removing the "Custom mediated deposit workflow for Hyku Commons" as an option for any tenants in the system.

Will be prioritizing this quite low.

[aprilrieger]

Find all tenants that have workflow option: Custom mediated deposit workflow for Hyku Commons
Remove Custom mediated deposit workflow for Hyku Commons as an option and set the default to the new/current default Default workflow