Search Only Tenant Should Ignore Collection Type #951
Labels
Comments
jeremyf
added a commit
that referenced
this issue
Dec 15, 2023
*Background:* A search_only tenant renders SOLR documents that had home tenants different than the search_only tenant. Part of that rendering includes the underlying Work's collection type. The SOLR document stores the `Hyrax::CollectionType`'s ID. The search_only tenant might have the same ID for `Hyrax::CollectionType` but it is not the same thing. Further, the home tenant might have an ID that is not in the search_only tenant, which results in an `ActiveRecord::RecordNotFound` error. Prior to this commit, we always attempted to render the badge. With this commit, we add some guarding logic to avoid rendering the badge when we're likely not rendering within the SOLR documents home tenant. Related to: - #951 - samvera/hyku#1815
32 tasks
jeremyf
added a commit
that referenced
this issue
Dec 15, 2023
*Background:* A search_only tenant renders SOLR documents that had home tenants different than the search_only tenant. Part of that rendering includes the underlying Work's collection type. The SOLR document stores the `Hyrax::CollectionType`'s ID. The search_only tenant might have the same ID for `Hyrax::CollectionType` but it is not the same thing. Further, the home tenant might have an ID that is not in the search_only tenant, which results in an `ActiveRecord::RecordNotFound` error. Prior to this commit, we always attempted to render the badge. With this commit, we add some guarding logic to avoid rendering the badge when we're likely not rendering within the SOLR documents home tenant. Related to: - #951 - samvera/hyku#1815
jeremyf
added a commit
that referenced
this issue
Dec 15, 2023
*Background:* A search_only tenant renders SOLR documents that had home tenants different than the search_only tenant. Part of that rendering includes the underlying Work's collection type. The SOLR document stores the `Hyrax::CollectionType`'s ID. The search_only tenant might have the same ID for `Hyrax::CollectionType` but it is not the same thing. Further, the home tenant might have an ID that is not in the search_only tenant, which results in an `ActiveRecord::RecordNotFound` error. Prior to this commit, we always attempted to render the badge. With this commit, we add some guarding logic to avoid rendering the badge when we're likely not rendering within the SOLR documents home tenant. Related to: - #951 - samvera/hyku#1815
jeremyf
added a commit
to samvera/hyku
that referenced
this issue
Dec 19, 2023
Related to Issues: - #1815 - scientist-softserv/palni-palci#951 Related to Pull Requests: - scientist-softserv/palni-palci#952
This was referenced Dec 19, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each work belongs to a collection type. That collection type is unique to a tenant.
When we’re in a search-only tenant (e.g. https://search.hykucommons.org), the collection types of the search tenant don’t line up with what is in each tenant. That is to say the search tenant has it’s own collection types; and when we’re using the cross site search we’re looking for the Work’s collection type relative to the search tenant.
The reason we're looking for a collection type is in part because we're interested in it's badge color; something that we may want to exclude on a search-only tenant.
This relates to:
The text was updated successfully, but these errors were encountered: