Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦄 Verify that Universal Viewer works for Resources #111

Open
4 tasks
laritakr opened this issue Aug 6, 2024 · 0 comments
Open
4 tasks

🦄 Verify that Universal Viewer works for Resources #111

laritakr opened this issue Aug 6, 2024 · 0 comments

Comments

@laritakr
Copy link
Contributor

laritakr commented Aug 6, 2024

Story

See pull request scientist-softserv/adventist_knapsack#733

In adventist knapsack Hyrax.config.curation_concerns does not include the Resource objects. It is comparing to solr_doc.hydra_model which is the full work type name. Since this file is from IiifPrint, it seems likely that the issue would also exist in Pals repo.

Adventist was fixed by bringing in iiif_manifest_presenter_factory_decorator.rb from IiifPrint to make the fix.

Acceptance Criteria

  • Verify whether a Resource with images in pals correctly displays the universal viewer

If there is an issue, make tickets to:

  • Make fix in IiifPrint
  • Update IiifPrint in Pals
  • Remove override in Adventist & update IiifPrint

Screenshots / Video

Testing Instructions and Sample Files

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants