Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iiif manifest is not generating correctly for universal viewer #730

Closed
3 tasks
Tracked by #725
laritakr opened this issue Aug 5, 2024 · 3 comments
Closed
3 tasks
Tracked by #725

Iiif manifest is not generating correctly for universal viewer #730

laritakr opened this issue Aug 5, 2024 · 3 comments
Assignees
Labels
contribute back code needs to be contributed to open source high priority IiifPrint M1 Milestone 1 Valkyrie

Comments

@laritakr
Copy link
Contributor

laritakr commented Aug 5, 2024

Story

When PDF files are split into multiple pages, they are expected to be viewable and searchable in the universal viewer. The manifest is not loading the canvas correctly.

Commit 630c7e5 introduced lonely operators which bypass the errors that were happening. Removing the lonely operators should allow finding what is missing.

Acceptance Criteria

  • Images appear appropriately in universal Viewer

Screenshots / Video

Manifest that is not working
{
"@context": [
"http://www.w3.org/ns/anno.jsonld",
"http://iiif.io/api/presentation/3/context.json"
],
"type": "Manifest",
"id": "https://cat.hyku.test/concern/datasets/a85de229-b43e-4d7f-816c-d4c57269a509/manifest",
"label": {
"none": [
"Another split attempt"
]
},
"rights": "http://rightsstatements.org/vocab/InC-EDU/1.0/",
"metadata": [
{
"label": {
"en": [
"Rights statement"
]
},
"value": {
"none": [
"<a href='http://rightsstatements.org/vocab/InC-EDU/1.0/'>In Copyright - Educational Use Permitted</a>"
]
}
}
],
"service": [
{
"@context": "http://iiif.io/api/search/1/context.json",
"profile": "http://iiif.io/api/search/1/search",
"label": "Search within this manifest",
"type": "SearchService1",
"id": "https://cat.hyku.test/catalog/a85de229-b43e-4d7f-816c-d4c57269a509/iiif_search"
}
],
"items": [],
"viewingHint": "paged",
"rendering": [
{
"@id": "https://cat.hyku.test/downloads/f2bf12d9-eaaa-4e7d-a878-b7fe5fa8e28e",
"label": null,
"format": "application/pdf"
}
]
}

Testing Instructions and Sample Files

  • Ensure the tenant is set up to use the universal viewer.
  • Find or create a work resource with image files attached
  • The images appear in the universal viewer.

Note

@laritakr laritakr self-assigned this Aug 6, 2024
@laritakr laritakr mentioned this issue Aug 6, 2024
laritakr added a commit that referenced this issue Aug 6, 2024
# Story

This fixes issues preventing universal viewer from building the manifest
with the items.

Two issues were found:
1) `Hyrax.config.curation_concerns` does not include the Resource
objects. It is comparing to `solr_doc.hydra_model` which is the full
work type name so the work types never match for resources. This is a
concerning bug because it comes from IiifPrint, and it is logical that
it would affect any resources in a valkyrized app using IiifPrint.
2) The logic to prevent the tn.jpg files from displaying in the viewer
broke because the presenter no longer responds to `label`.

Refs #730

# Expected Behavior Before Changes

Manifest had no items so it was empty.

# Expected Behavior After Changes

Manifest includes image files of both file sets and child works.

# Screenshots / Video

<details>
<summary></summary>

![Screenshot 2024-08-06 at 4 20
37 PM](https://github.com/user-attachments/assets/0b8ed05c-cde7-4734-a448-3ad5806e7e17)

</details>

# Notes
@laritakr laritakr added tech debt contribute back code needs to be contributed to open source IiifPrint labels Aug 23, 2024
@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Aug 26, 2024
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Aug 26, 2024

QA RESULTS: ❌ NEEDS REWORK

TESTED ON STAGING

The image does not display in the UV even though it's attached to the work.

/manifest.json produces 500 internal server error:

Image

Image

locally:

items => [ ] there should be something in here

Image

@laritakr
Copy link
Contributor Author

Need to rework how the viewers show.

Based on flipper setting and split status, we see:

  • Default viewer PDF.js, no split >> shows pdfs viewer
  • Default viewer: UV, no split >> uses representative_media partial and UV - black box because no split
  • Default viewer PDF.js, split into child works, >> no viewer, shows default thumbnail
  • Default viewer: UV, split >> uses UV

@ShanaLMoore
Copy link
Contributor

This issue will be covered and tested in #760

@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute back code needs to be contributed to open source high priority IiifPrint M1 Milestone 1 Valkyrie
Projects
Status: Done
Development

No branches or pull requests

3 participants