Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenCV Use case #142

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Add OpenCV Use case #142

merged 7 commits into from
Apr 8, 2024

Conversation

hinerm
Copy link
Member

@hinerm hinerm commented Apr 1, 2024

No description provided.

@hinerm
Copy link
Member Author

hinerm commented Apr 1, 2024

@elevans what do you think of this example?

@hinerm hinerm mentioned this pull request Apr 1, 2024
Closed
@ctrueden ctrueden requested a review from elevans April 1, 2024 21:03
@elevans
Copy link
Member

elevans commented Apr 1, 2024 •
edited
Loading

@hinerm I pulled the opencv-use branch and tried your example de-noise script, but it doesn't work. My output image looks the same as my input image (sample_16bit_T24.png) regardless of whatever setting I specify. Is there something more that I need to do to make this work?

edit: Just updating this for the record. This use case works when using Fiji with jaunch!

hinerm added 2 commits April 3, 2024 20:38
@hinerm @elevans
OpenCV: expose NL Means denoise
9206baa
@hinerm @elevans
opencv-ops: make imagej-opencv a runtime dep
9d1344e 
Because our op.yaml exposes methods from imagej-opencv it is not just
test scope.
elevans
elevans requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@elevans elevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example @hinerm! I it just needs some clarification on what the parameters do. It's too bad that for now this is limited to uint8 outputs.

docs/ops/images/sample_16bit_T24.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this file should live on media.imagej.net and when its ready media.scijava.org instead of the repo proper.

hinerm and others added 3 commits April 5, 2024 10:53
@hinerm
Add OpenCV NlMeans denoise example
c1031da
@hinerm
OpenCV Denoise use: return image if successful
311d98e 
Instead of always opening a result, only do so if the ops denoise call
was actually successful.
@elevans @hinerm
Add Python script to opencv denoise example
1d4a2c1 
This commit also simplifies the Groovy script.
elevans added 2 commits April 5, 2024 16:09
@elevans
Improve opencv denoise use case
06f5c7f 
This commit adds more details about the denoise
operation and describes what each of the parameters do.
Additional this commit adds an image of the expected output
with the recommended starting values.
@elevans
Add sphinx-copycode button to the docs
698717a
@elevans elevans merged commit 6f99a25 into main Apr 8, 2024
2 checks passed
@hinerm hinerm deleted the opencv-use branch April 8, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevans elevans elevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hinerm @elevans