-
Notifications
You must be signed in to change notification settings - Fork 35
Update FlatLaf, RSyntaxTextArea, AutoComplete #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @tferr. The CI failure is due to an ongoing incompatibility between ImageJ and ImageJ2's legacy layer. It doesn't look like this update broke anything new AFAICT though, so I'm merging it now. |
There is actually a failure now with script-editor:
@tferr If you have time to fix it, great, otherwise I'll take a look as soon as I can, in conjunction with the other needed BOM fixes. |
@ctrueden, I will look at it. I have been using it on my computer without noticing anything (I always do before submitting a PR here). I guess I don't have the same versions of all dependencies!?. Will ping you if I need guidance. |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/84 |
This fixes the issue detailed in scijava/pom-scijava#288 Context: In newer versions of RSyntaxtTextArea, AbstractJFlexCTokenMaker adds an abstract yystate() method intended to return the current state of a JFlex lexer. Since it is abstract, it must be implemented by any concrete subclass, so we patch ImageJMacroTokenMaker so that the current zzLexicalState is returned Tested with: `mvn clean package -Denforcer.skip`
@ctrueden , scijava/script-editor#72 should fix this |
This fixes the issue detailed in scijava/pom-scijava#288. Context: In newer versions of RSyntaxtTextArea, AbstractJFlexCTokenMaker adds an abstract yystate() method intended to return the current state of a JFlex lexer. Since it is abstract, it must be implemented by any concrete subclass, so we patch ImageJMacroTokenMaker so that the current zzLexicalState is returned. Tested with: `mvn clean package -Denforcer.skip` Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
This accommodates RSyntaxTextArea 3.6.0; see #288.
No description provided.