Add abstract delegate converter class #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #182 and adds
AbstractDelegateConverter
that allows to specify new converters that chain together two subsequent conversions like this:I am not sure about how to implement the test: is it possible to create private nested classes that can be discovered asPlugin
s during test time?I'd appreciate some advice here if you have time, @ctrueden.EDIT: I think I figured it out. I force-pushed the latest commit, adding a test for the abstract class. This should now be ready for review.
Test coverage of the added classes: 100% 🙂