Update OKHTTP dependency #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it remove requirement for scijava-common version as it is managed
Signed-off-by: tferr <tiago.tferr@gmail.com>
tferr
added a commit
to tferr/pom-scijava
that referenced
this pull request
May 27, 2020
This requires scijava/scijava-io-http#5 to be accepted and merged!
|
Good idea! |
|
@tferr Argh, I didn't notice that you bumped the version number. You shouldn't do this manually. Use the |
|
@ctrueden , I did use the release-version.sh script: Forked the project. did the changes, ran release-version.sh, started the PR. How did I manage to screw up? |
|
The Anyway, no worries—I cut the release myself, resetting the master branch's SNAPSHOT back to 0.2.2-SNAPSHOT again, so no harm done. 👍 |
|
@tferr I did notice one worrisome thing, though: a However, it seems that version 0.2.0 also emits this exception. And it does not fail any tests. I don't suppose you looked at the code carefully enough to verify whether that's supposed to happen? @gab1one Do you remember? I generally try to avoid dumping exceptions to the console when they are expected, in favor of catching them... |
|
@ctrueden, no I did not peruse the code. I looked for deprecations and tests completion. I also saw that exception but because it was also happening with the old okhttp version, I didn't think much of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gab1one, @ctrueden :
SNT uses okhttp a lot. We are currently using v4.7.2. There is a funky issue in some combinations of update sites (I really didn't have time to look into it: it was hard to understand how it was happening) the okhttp jar from our update site does not get downloaded: the updater considers the okhttp from scijava-io-http instead. This attempts to bring them into sync. Eitherway, you guys are using a 3year old release, so updating is certainly beneficial!