-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlotService to SciJava #43
Conversation
They depend on converters Plot -> JFreeChart, and the ChartPanel which is part of the JFreeChart library.
This allows to store a plot as SVG with the SciJava IOService.
The converter is based on converters Plot -> JFreeChart
I am hoping to work on a new ImageJ+Fiji release after January 22, that includes these features. There is also synergy here with the PlotService maybe being usable from Jupyter notebook. Looking forward to trying it out. |
What's the status of this PR? Can I would love to have |
@imagejan Been endlessly too busy, sorry. 😞 Even after all this time, I fear I haven't really studied the I'd also like to think very carefully about plotting, to minimize the chance of needing to deprecate this API in future. Some concerns I have include:
|
Hi @maarzt, I'd like to help move this forward if I am able to, maybe we can chat about it if you have time? I can't find the scijava-plot repo without dependencies, did you maybe not push your latest version to https://github.com/maarzt/scijava-plot or am I misunderstanding something? |
@frauzufall Thank you for looking at this. You were right, I forgot to push my changes to scijava-plot/master. Now it's up to date, dependencies are removed :) |
As far as I can tell, the commits of this PR were merged with 1bf54bd, and this can be closed. |
@imagejan I think you are right. imagej/imagej-legacy#208 is still pending, though. |
I split the PlotService as discussed with @ctrueden recently. It now consist of three parts:
I might have overused converters a bit, what do you think? There are the following converters
The converters 1 and 2 are used to display the plot using ChartPanel of JFreeChart.
The converters 4 and 5 are there because they do what users want: Convert a plot into a datatype that they know like ImagePlus or Img.
The converter 3 exists to make imagej-legacy independent of JFreeChart.
This is what I think needs to be done to get plot service released: