Update JComboBox choices during SwingChoiceWidget refresh #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes ensure JComboBox items update during DynamicCallbacks
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
imagejan
reviewed
Oct 22, 2020
src/main/java/org/scijava/ui/swing/widget/SwingChoiceWidget.java
Outdated
Show resolved
Hide resolved
|
With permission of @ctrueden (see this gitter post) I'm merging this PR now. I tested it in the UI with the command from the tutorial, and it works beautifully. I didn't notice any breakage in other widgets. I did try to implement a unit test for this functionality, but didn't succeed getting it right... my work in progress is in c21f6a1. If someone manages to write a working unit test for this UI behavior, I think it would be great to have it. Otherwise, we might want to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JComboBox items are not updated during DynamicCallbacks as noted in the comments of the DynamicCallback example - https://github.com/imagej/tutorials/blob/d3ff8e818bb26cb4713371878b239b36cb7d4877/maven-projects/dynamic-commands/src/main/java/DynamicCallbacks.java#L29-L31
@imagejan suggested implementing JComboBox updates in the doRefresh() method of SwingChoiceWidget to fix this problem on the forum - https://forum.image.sc/t/repaint-scijava-command-ui/42835/2
I quickly wrote a draft of this so that changes in the options of the dialog can update the JComboBox items. This is very useful for situations where you want one JComboBox to change items based on another.
Maybe there are deeper reasons to not implement a fix in this manner. Also, there might be cleaner implementations, but since I was already testing, I figured I would go ahead and file the PR.