Laf fixes #79
Laf fixes #79
Conversation
|
@tferr This is great! Two quick nitpicks: 1) this work needs to be rebased over the latest master branch (there are conflicts); 2) I am not a fan of removing menu bars/items just because right-click context menus exist. It is considered bad UI design (at least historically by Apple HCI documents) to have functionality that is only accessible in context menus. See e.g. web browsers, which have Cut/Copy/Paste et al. in both context menu and an Edit menu. About the spinner size 50: it looks like that got added with 3a91c1a, when @imagejan added support for floating-point spinner values. I'm guessing it was done experimentally to make the floating point values appear in a better way than the default? So before removing it, we should test spinners with floating point values to see how they behave with these patches in place. |
AhAh, makes sense! But we probably need to make it that the '50' scales up proportionally to the font in use. On the menubar: Hehe, we know things are looking sharp when all it is left are just these almost-futilities. 😉 |
Console: Define height relative to font size currently in use. This ensures it adopts the same height as other widgets in hiDPI screens Console: Compute scroll Pane dimensions from font metrics. I.e., rather than using a hardwired dimension that does not scale well on HiDPI, use line/columns instead. SwingColorWidget: Do not use harwired height.
|
Removed the controversial JSpinner and Console menu bar changes. Should be ready to merge now. @imagejan: I would still ask you to look at the constant widths/heights in the JSpinner and the FileListWidget. |
|
@ctrueden, can this be merged? I need to mentally move on, and it is hard to test the new release when there is stuff like this still pending |
|
@tferr Thanks for the ping. |
I finally looked into things that are not scaling properly under FlatLaf. I found only 3 issues, each associated with one commit here, to make it easier to cherrypick things.
Console
Commit 37a3cb2: The console dimensions were hardwired, so I tried to make it so that dimensions are set in terms of columns/lines computed from the active monospaced font. Also the menu bar contains only a single "Clear" command. I find this confusing because that clear command does nothing when the Log tab is selected. Since there is a 'Clear' command in the contextual menus of both tabs, I propose we remove it.
Color widgets
Commit 01459f8: It was using a hardwired height. Now it is scalable, with height matching that of a JTextField. imagej/imagej-ui-swing#90 extends this to color tables
Number widgets
Commit 95bc9b3: I could not find any reason why this code (discussed in #77) needs to exist:
scijava-ui-swing/src/main/java/org/scijava/ui/swing/widget/SwingNumberWidget.java
Lines 131 to 133 in 40bd474
A width of 50 seems arbitrary, and everything seems to work fine if we just remove that code!? @imagejan, what do you think?
FileList widgets
SwingFileListWidgetwas the other place where I found hardwired dimensions, namely here:scijava-ui-swing/src/main/java/org/scijava/ui/swing/widget/SwingFileListWidget.java
Line 115 in 47c0e91
(@imagejan, without specifying dimensions the JscrollPane does collapse, but perhaps something like
JList#setPrototypeCellValue("prototype value");could be used to set things in a 'scalable' manner?(update: edited for clarity)