Compress compiled block using { unsued: "keep_assign" } #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this fixes browserify-transformed ndarray-fill with uglify-js@2.8.x - see https://github.com/mishoo/UglifyJS2/pull/1450/files for more details - add test
etpinard
added a commit
to etpinard/ndarray-fill
that referenced
this pull request
Mar 14, 2017
- to ensure scijs/cwise#13 is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug showing in browserify-transformed
ndarray-fillwithuglify-js@2.8.x.This bug was first reported in plotly/plotly.js#1450 (comment) and was introduced in mishoo/UglifyJS#1450 which was published as part of
uglify-js@2.8.0. For more info on the{ unused: "keep_assign" }rule see the compressor options. In essence, without thatunusedsetting the compiled block removes the_inline_1_arg1_references:This PR also adds tests for fill-like operations similar to
ndarray-fill.