Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request library with got #56

Closed
wants to merge 1 commit into from
Closed

Replace request library with got #56

wants to merge 1 commit into from

Conversation

bacali95
Copy link

@bacali95 bacali95 commented Aug 26, 2021

The request library is now deprecated and it is having some vulnerabilities that will not have any fixes anytime soon, this PR is to replace it with got a more maintainable HTTP library.

@bacali95
Copy link
Author

@mikolalysenko can you please take a look :)

@LincolnPuzey
Copy link

We would appreciate this change being released since another vulnerability effecting request has been raised GHSA-896r-f27r-55mw

It is in the json-schema library and request has the following chain request > http-signature > jsprim > json-schema

Issue raised in the request library request/request#3394

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants