-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake 3.31 is broken: CMake Error: Could not find CMAKE_ROOT !!! #557
Comments
I’d be fine to yank this while we figure it out, but it doesn’t seem like I have permission to yank, @jcfr? |
can confirm we are getting this error too (from installing wheels for cvxpy->osqp->qdldl->cmake). |
Came here to say so, also can you guys link to this repo from pypi it was a pain to find it |
+1 |
I don’t have permission to yank, so I’ll have to try to fix this tonight. I’m assuming it’ll show up on any system that does not have a system CMake (I.e, like ci or my machine) |
Yanking now. |
Ah, wow, this only shows up if there's a CMakeLists.txt present. I hadn't realized that at first; my docker reproducer wasn't reproducing but adding the CMakeLists.txt does trigger it. Got the bug. CMake's inspecting the first arg to find the root path. But in #555 I didn't give it the full path. |
We have links pointing back here, both on PyPI: cmake-python-distributions/pyproject.toml Line 36 in 0c316e2
And in the readme: cmake-python-distributions/README.rst Lines 88 to 90 in 0c316e2
Not sure where else we could add more links? |
New 3.31.0.1 release will be up a few hours. |
Thanks @henryiii for sorting this out 🙏💯 |
See this error in the CI, which can be reproduced:
reproduce:
https://gist.github.com/njzjz/1c8f360ebc4457bf0d0f6ea86978b78b
CI log: https://github.com/deepmodeling/deepmd-kit/actions/runs/11758764445/job/32757483294#step:3:1
The text was updated successfully, but these errors were encountered: