Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake 3.31 is broken: CMake Error: Could not find CMAKE_ROOT !!! #557

Closed
njzjz opened this issue Nov 9, 2024 · 11 comments · Fixed by #558
Closed

cmake 3.31 is broken: CMake Error: Could not find CMAKE_ROOT !!! #557

njzjz opened this issue Nov 9, 2024 · 11 comments · Fixed by #558

Comments

@njzjz
Copy link
Contributor

njzjz commented Nov 9, 2024

See this error in the CI, which can be reproduced:

CMake Error: Could not find CMAKE_ROOT !!!
CMake has most likely not been installed correctly.
Modules directory not found in
/usr/local/share/cmake-3.31
CMake Error: Error executing cmake::LoadCache(). Aborting.

reproduce:
https://gist.github.com/njzjz/1c8f360ebc4457bf0d0f6ea86978b78b

CI log: https://github.com/deepmodeling/deepmd-kit/actions/runs/11758764445/job/32757483294#step:3:1

@henryiii
Copy link
Contributor

henryiii commented Nov 9, 2024

I’d be fine to yank this while we figure it out, but it doesn’t seem like I have permission to yank, @jcfr?

@Transurgeon
Copy link

can confirm we are getting this error too (from installing wheels for cvxpy->osqp->qdldl->cmake).

@Sytten
Copy link

Sytten commented Nov 9, 2024

Came here to say so, also can you guys link to this repo from pypi it was a pain to find it

@nucflash
Copy link

nucflash commented Nov 9, 2024

+1

@henryiii
Copy link
Contributor

I don’t have permission to yank, so I’ll have to try to fix this tonight. I’m assuming it’ll show up on any system that does not have a system CMake (I.e, like ci or my machine)

@jcfr
Copy link
Contributor

jcfr commented Nov 10, 2024

Yanking now.

@jcfr
Copy link
Contributor

jcfr commented Nov 10, 2024

3.31.0 yanked ✅️


Screenshot_20241109_211723_Chrome.jpg

@henryiii
Copy link
Contributor

Ah, wow, this only shows up if there's a CMakeLists.txt present. I hadn't realized that at first; my docker reproducer wasn't reproducing but adding the CMakeLists.txt does trigger it.

Got the bug. CMake's inspecting the first arg to find the root path. But in #555 I didn't give it the full path.

@henryiii
Copy link
Contributor

@Sytten

also can you guys link to this repo from pypi it was a pain to find it

We have links pointing back here, both on PyPI:

Source = "https://github.com/scikit-build/cmake-python-distributions"

And in the readme:

* Documentation: https://cmake-python-distributions.readthedocs.io/en/latest/
* Source code: https://github.com/scikit-build/cmake-python-distributions
* Mailing list: https://groups.google.com/forum/#!forum/scikit-build

Not sure where else we could add more links?

@henryiii
Copy link
Contributor

New 3.31.0.1 release will be up a few hours.

@jcfr
Copy link
Contributor

jcfr commented Nov 11, 2024

Thanks @henryiii for sorting this out 🙏💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants