Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ppc64le & s390x manylinux2014 builds #130

Merged
merged 3 commits into from
May 7, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 5, 2021

This adds ppc64le & s390x builds to travis-ci in order to provide manylinux2014 wheels for those platforms.

Fix #125

@mayeut mayeut force-pushed the add-s390x-ppc64le branch from fa2e2fa to 0e72416 Compare April 5, 2021 18:28
@jcfr jcfr force-pushed the add-s390x-ppc64le branch from 0e72416 to 7550165 Compare April 7, 2021 21:43
@jcfr
Copy link
Contributor

jcfr commented Apr 7, 2021

@mayeut as the dependent PRs have been merged, I just rebased this one and tweaked the commit message associated with the pinning of OpenSSL.

Do not hesitate to further tweak.

@mayeut mayeut force-pushed the add-s390x-ppc64le branch from 7550165 to 4fa29c4 Compare April 7, 2021 21:47
@mayeut
Copy link
Contributor Author

mayeut commented Apr 7, 2021

@jcfr,

I think we did approximately the same thing at the same time on this one. Thus I discarded your changes after rebasing on master by mistake & can't see the tweaks on OpenSSL anymore...

I'm done for the day, shouldn't conflict anymore on force push.

@jcfr jcfr force-pushed the add-s390x-ppc64le branch from 4fa29c4 to 651e13e Compare April 9, 2021 05:46
@jcfr
Copy link
Contributor

jcfr commented Apr 9, 2021

TravisCI build associated with ppc64le arch failed with a download error related to rust package

Suspecting an intermittent download failure, I restarted the specific travisCI job

@jcfr
Copy link
Contributor

jcfr commented Apr 9, 2021

@jcfr jcfr mentioned this pull request Apr 9, 2021
@mayeut mayeut force-pushed the add-s390x-ppc64le branch from 651e13e to 5772f7e Compare April 9, 2021 23:20
@mayeut mayeut changed the title Add ppc64le & s390x manylinux2014 builds ci: add ppc64le & s390x manylinux2014 builds Apr 10, 2021
@mayeut
Copy link
Contributor Author

mayeut commented Apr 10, 2021

@jcfr, the OpenSSL comment was a leftover of #128 attempts. I just removed it now that #128 has been merged in using new dockcross images (dockcross/dockcross#481) not requiring to pin cryptography to an even lower version.

I updated the arguments of the rust compiler installation too the same ones used in cryptography and that seems to do the trick for the ppc64le download (uses a minimal, stable toolchain).

Finally, there were some resource issues on ppc64le that were worked around limiting the number of parallel builds to 4.

@mayeut mayeut marked this pull request as ready for review April 10, 2021 09:21
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfr Looks good to me. Worth including before 3.19.1, perhaps?

@mayeut mayeut mentioned this pull request May 1, 2021
@henryiii henryiii merged commit 9ae3719 into scikit-build:master May 7, 2021
@henryiii
Copy link
Contributor

henryiii commented May 7, 2021

To be useful, this probably needs to be applied to https://github.com/scikit-build/ninja-python-distributions too?

@mayeut mayeut deleted the add-s390x-ppc64le branch May 7, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP 599 + PEP 600 archs
3 participants