chore(ci): bump test_sdist python from 3.11 to 3.12
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
mayeut
changed the title
test_sdist python from 3.11 to 3.12
mayeut
force-pushed
the
bump-sdist-build
branch
from
0fdb659
to
854b31d
Compare
mayeut
commented
Oct 21, 2023
src/cmake/__init__.py
Outdated
| from ._version import get_versions | ||
| from ._version import version as __version__ | ||
|
|
||
| __all__ = ["__version__", "CMAKE_DATA", "CMAKE_BIN_DIR", "CMAKE_DOC_DIR", "CMAKE_SHARE_DIR", "cmake", "cpack", "ctest"] |
There was a problem hiding this comment.
Should we really expose all those CMAKE variables ?
There was a problem hiding this comment.
I know CMAKE_BIN_DIR is used other places. I don’t remember where.
mayeut
force-pushed
the
bump-sdist-build
branch
from
854b31d
to
8452772
Compare
henryiii
approved these changes
Dec 2, 2023
It was always skipped in CI tests and relies on plugins that do not support python 3.12. Remove the file and move the version check to test_cmake.
mayeut
force-pushed
the
bump-sdist-build
branch
from
8452772
to
abff04b
Compare
Merged
jcfr
added a commit
to mayeut/cmake-python-distributions
that referenced
this pull request
Feb 15, 2024
…ualenv The use of the `virtualenv` pytest fixture become obsolete following commit 280260d ("chore(ci): bump `test_sdist` python from 3.11 to 3.12 (scikit-build#423)", 2023-12-02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #422