Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nox: session "tests" failed because of TypeError: _run_tests() missing 1 required keyword-only argument: 'install_args' #404

Closed
mgorny opened this issue Jun 23, 2023 · 3 comments · Fixed by #408

Comments

@mgorny
Copy link

mgorny commented Jun 23, 2023

$ nox -e tests
nox > Running session tests
nox > Creating virtual environment (virtualenv) using python3.12 in .nox/tests
nox > Session tests raised exception TypeError("_run_tests() missing 1 required keyword-only argument: 'install_args'")
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/nox/sessions.py", line 761, in execute
    self.func(session)
  File "/usr/lib/python3.12/site-packages/nox/_decorators.py", line 75, in __call__
    return self.func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/scikit-build-core/noxfile.py", line 68, in tests
    _run_tests(session, extras=["test-meta,test-numpy"])
TypeError: _run_tests() missing 1 required keyword-only argument: 'install_args'
nox > Session tests failed.
@LecrisUT
Copy link
Collaborator

Nox or python 3.12 issue I wonder. The CI only tests with python 3.11

@henryiii
Copy link
Collaborator

I bet this is something I broke when I refactored this in nox in 0.4.6 to use the smaller individual extras.

We do test on 3.12, but we don't run all the nox sessions in CI, I mostly do that locally.

henryiii added a commit that referenced this issue Jun 23, 2023
Adding mypy checking found three (edit: technically two, the Path/str
one is a bug in nox's types, I think) bugs in the noxfile. One of them
closes #404.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@mgorny
Copy link
Author

mgorny commented Jun 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants