fix: report cmake/ninja requried if already present #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyrowland
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Running this version fixes running my project via tox, so I am very happy with it. I note that there aren't any additional tests to check for this behaviour - is this something that is worth adding, or are you happy that it is a small enough change. Adding a test would be quite challenging with the current changes to protect_get_requires() as that explicitly always says that cmake/ninja are not installed (and is autoused), so we can't test that they are still requested when they are installed.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/toxcache
branch
from
5814eb1
to
526a36c
Compare
|
I'm okay with it for now, I think (especially since I saw it broke the tests as expected without the modification above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #458.
@bennyrowland, I think this either fixes this or is a good start.