-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: exclude installed files if listed in exclude #652
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 86.32% 86.30% -0.02%
==========================================
Files 64 64
Lines 3306 3316 +10
==========================================
+ Hits 2854 2862 +8
- Misses 452 454 +2 ☔ View full report in Codecov by Sentry. |
25ff81d
to
52b0276
Compare
817ed39
to
f5fc9d8
Compare
"wheel.exclude": "src/simplest/sdist_only.txt", | ||
"wheel.exclude": [ | ||
"simplest/sdist_only.txt", | ||
"simplest/generated_no_wheel.txt", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a behavior change, though I'd be willing to consider the old behavior a bug. Previously, wheel exclude matched on the SDist/source path. Now it matches on the final wheel path.
Not sure to just call this a bug fix, or to add back-compat for it via minimum-version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No packages (by either PyPI search or GitHub search) were found that would be affected by this change, so the plan is to make it as a bug fix, document this in the changelog, and be open to adding a compat setting for it if someone does end up needing it.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
e3f7b4e
to
2c1c008
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
As mentioned in our recent Community Meeting.