Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move some cmake options to build section #793

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jul 2, 2024

Fix #747.

@henryiii henryiii force-pushed the henryiii/feat/renamebuild branch 4 times, most recently from f621c4b to 6fa038c Compare July 3, 2024 13:48
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/renamebuild branch from 6fa038c to 735b665 Compare July 5, 2024 16:11
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (2942230) to head (735b665).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
...cikit_build_core/settings/skbuild_read_settings.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   82.00%   82.01%           
=======================================
  Files          68       68           
  Lines        3935     3958   +23     
=======================================
+ Hits         3227     3246   +19     
- Misses        708      712    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 3287d2c into main Jul 6, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/feat/renamebuild branch July 6, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renames now that we have a build section
1 participant