Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn if cmake/ninja in build system requirements #803

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

henryiii
Copy link
Collaborator

Fix #780.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (0e67e57) to head (fc305fc).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/build/wheel.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   82.92%   82.90%   -0.03%     
==========================================
  Files          69       69              
  Lines        3919     3926       +7     
==========================================
+ Hits         3250     3255       +5     
- Misses        669      671       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 7af8187 into main Jul 10, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/feat/warncmakeninja branch July 10, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger warning if build-system.requires contains cmake or ninja
1 participant