Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatically refresh the cache when required #870

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

Fix #869 by detecting a moved isolated environment and issuing --fresh. Also go ahead and use this for the moved source dir case too.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/fresh branch from a5f3332 to 2b329c7 Compare August 22, 2024 16:08
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.88%. Comparing base (26ca7ed) to head (815b1b6).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/cmake.py 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   83.98%   83.88%   -0.11%     
==========================================
  Files          74       74              
  Lines        4372     4381       +9     
==========================================
+ Hits         3672     3675       +3     
- Misses        700      706       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title fix: automatically add --fresh when required fix: automatically refresh the cache when required Aug 22, 2024
@henryiii henryiii merged commit cafc039 into main Aug 22, 2024
57 of 59 checks passed
@henryiii henryiii deleted the henryiii/fix/fresh branch August 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake fails to find SWIG on rebuilds
1 participant