Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only strip Release and MinSizeRel builds by default #898

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

henryiii
Copy link
Collaborator

Fix #875.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (ef43b65) to head (0224898).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files          74       74           
  Lines        4393     4393           
=======================================
  Hits         3684     3684           
  Misses        709      709           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 8380c9e into main Sep 11, 2024
63 checks passed
@henryiii henryiii deleted the henryiii/fix/striprel branch September 11, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does scikit-build-core strip debug info by default?
1 participant