Revert 'recursively_apply' hiding (TBD in another PR).

src/awkward/_connect/jax/trees.py

@@ -21,7 +21,7 @@ def action(node, **kwargs):
         if isinstance(node, ak.contents.NumpyArray):
             data_ptrs.append(node.data)
 
-    layout._recursively_apply(action=action, return_array=False, numpy_to_regular=False)
+    layout.recursively_apply(action=action, return_array=False, numpy_to_regular=False)
 
     return data_ptrs
 
@@ -43,7 +43,7 @@ def action(node, **kwargs):
                     buffer, parameters=node.parameters, backend=backend
                 )
 
-    return layout._recursively_apply(action=action, numpy_to_regular=False)
+    return layout.recursively_apply(action=action, numpy_to_regular=False)
 
 
 T = TypeVar(

src/awkward/_connect/numpy.py

@@ -254,7 +254,7 @@ def unary_action(layout, **ignore):
                 assert isinstance(result, tuple) and len(result) == 1
                 return result[0]
 
-        out = inputs[where]._recursively_apply(
+        out = inputs[where].recursively_apply(
             unary_action, behavior, function_name=ufunc.__name__, allow_records=False
         )
 

src/awkward/contents/bitmaskedarray.py

@@ -619,7 +619,7 @@ def _completely_flatten(self, backend, options):
         else:
             return [self]
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._backend.nplike.known_shape:
@@ -636,7 +636,7 @@ def _recursively_apply_impl(
             def continuation():
                 return make(
                     self._mask,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,
@@ -653,7 +653,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth,

src/awkward/contents/bytemaskedarray.py

@@ -1002,7 +1002,7 @@ def _completely_flatten(self, backend, options):
         else:
             return [self]
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._backend.nplike.known_shape:
@@ -1019,7 +1019,7 @@ def _recursively_apply_impl(
             def continuation():
                 return make(
                     self._mask,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,
@@ -1034,7 +1034,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth,

src/awkward/contents/content.py

@@ -1523,7 +1523,7 @@ def completely_flatten(
     def _completely_flatten(self, backend, options):
         raise ak._errors.wrap_error(NotImplementedError)
 
-    def _recursively_apply(
+    def recursively_apply(
         self,
         action: ActionType,
         behavior: dict | None = None,
@@ -1536,7 +1536,7 @@ def _recursively_apply(
         return_array: bool = True,
         function_name: str | None = None,
     ) -> Content | None:
-        return self._recursively_apply_impl(
+        return self._recursively_apply(
             action,
             behavior,
             1,
@@ -1552,7 +1552,7 @@ def _recursively_apply(
             },
         )
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self,
         action: ActionType,
         behavior: dict | None,

src/awkward/contents/emptyarray.py

@@ -336,7 +336,7 @@ def _to_numpy(self, allow_missing):
     def _completely_flatten(self, backend, options):
         return []
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if options["return_array"]:

src/awkward/contents/indexedarray.py

@@ -1012,7 +1012,7 @@ def _to_numpy(self, allow_missing):
     def _completely_flatten(self, backend, options):
         return self.project()._completely_flatten(backend, options)
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if (
@@ -1038,7 +1038,7 @@ def _recursively_apply_impl(
             def continuation():
                 return make(
                     index,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,
@@ -1052,7 +1052,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth,

src/awkward/contents/indexedoptionarray.py

@@ -1539,7 +1539,7 @@ def _completely_flatten(self, backend, options):
         else:
             return [self]
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if (
@@ -1569,7 +1569,7 @@ def _recursively_apply_impl(
             def continuation():
                 return make(
                     index,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,
@@ -1583,7 +1583,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth,

src/awkward/contents/listarray.py

@@ -1404,7 +1404,7 @@ def _completely_flatten(self, backend, options):
             flat = next.content[next.offsets[0] : next.offsets[-1]]
             return flat._completely_flatten(backend, options)
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if (
@@ -1429,7 +1429,7 @@ def continuation():
                 return ListArray(
                     starts,
                     stops,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth + 1,
@@ -1443,7 +1443,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth + 1,

src/awkward/contents/listoffsetarray.py

@@ -2002,7 +2002,7 @@ def _completely_flatten(self, backend, options):
             flat = self._content[self._offsets[0] : self._offsets[-1]]
             return flat._completely_flatten(backend, options)
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._backend.nplike.known_shape and self._backend.nplike.known_data:
@@ -2019,7 +2019,7 @@ def _recursively_apply_impl(
             def continuation():
                 return ListOffsetArray(
                     offsets,
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth + 1,
@@ -2033,7 +2033,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth + 1,

src/awkward/contents/numpyarray.py

@@ -1287,11 +1287,11 @@ def _completely_flatten(self, backend, options):
             )
         ]
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._data.ndim != 1 and options["numpy_to_regular"]:
-            return self.to_RegularArray()._recursively_apply_impl(
+            return self.to_RegularArray()._recursively_apply(
                 action, behavior, depth, depth_context, lateral_context, options
             )
 

src/awkward/contents/recordarray.py

@@ -961,7 +961,7 @@ def _completely_flatten(self, backend, options):
                 )
             )
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._backend.nplike.known_shape:
@@ -980,7 +980,7 @@ def continuation():
                     )
                 return RecordArray(
                     [
-                        content._recursively_apply_impl(
+                        content._recursively_apply(
                             action,
                             behavior,
                             depth,
@@ -1000,7 +1000,7 @@ def continuation():
 
             def continuation():
                 for content in contents:
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,

src/awkward/contents/regulararray.py

@@ -1281,7 +1281,7 @@ def _completely_flatten(self, backend, options):
             flat = self._content[: self._length * self._size]
             return flat._completely_flatten(backend, options)
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if self._backend.nplike.known_shape:
@@ -1293,7 +1293,7 @@ def _recursively_apply_impl(
 
             def continuation():
                 return RegularArray(
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth + 1,
@@ -1309,7 +1309,7 @@ def continuation():
         else:
 
             def continuation():
-                content._recursively_apply_impl(
+                content._recursively_apply(
                     action,
                     behavior,
                     depth + 1,

src/awkward/contents/unionarray.py

@@ -1509,7 +1509,7 @@ def _completely_flatten(self, backend, options):
             )
         return out
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if options["return_array"]:
@@ -1523,7 +1523,7 @@ def continuation():
                     self._tags,
                     self._index,
                     [
-                        content._recursively_apply_impl(
+                        content._recursively_apply(
                             action,
                             behavior,
                             depth,
@@ -1540,7 +1540,7 @@ def continuation():
 
             def continuation():
                 for content in self._contents:
-                    content._recursively_apply_impl(
+                    content._recursively_apply(
                         action,
                         behavior,
                         depth,

src/awkward/contents/unmaskedarray.py

@@ -464,7 +464,7 @@ def _completely_flatten(self, backend, options):
         else:
             return [self]
 
-    def _recursively_apply_impl(
+    def _recursively_apply(
         self, action, behavior, depth, depth_context, lateral_context, options
     ):
         if options["return_array"]:
@@ -475,7 +475,7 @@ def _recursively_apply_impl(
 
             def continuation():
                 return make(
-                    self._content._recursively_apply_impl(
+                    self._content._recursively_apply(
                         action,
                         behavior,
                         depth,
@@ -489,7 +489,7 @@ def continuation():
         else:
 
             def continuation():
-                self._content._recursively_apply_impl(
+                self._content._recursively_apply(
                     action,
                     behavior,
                     depth,

src/awkward/operations/ak_cartesian.py

@@ -339,7 +339,7 @@ def getfunction2(layout, depth, **kwargs):
                                 "characters of a string; please split it into lists"
                             )
                         )
-                    nextlayout = layout._recursively_apply(
+                    nextlayout = layout.recursively_apply(
                         getgetfunction1(inside), behavior
                     )
                     return newaxis(nextlayout, outside)
@@ -350,7 +350,7 @@ def getfunction2(layout, depth, **kwargs):
 
         def apply(x, i):
             layout = ak.operations.to_layout(x, allow_record=False, allow_other=False)
-            return layout._recursively_apply(getgetfunction2(i), behavior)
+            return layout.recursively_apply(getgetfunction2(i), behavior)
 
         toflatten = []
         if nested is None or nested is False:

src/awkward/operations/ak_categories.py

@@ -36,6 +36,6 @@ def action(layout, **kwargs):
 
     layout = ak.operations.to_layout(array, allow_record=False, allow_other=False)
     behavior = ak._util.behavior_of(array)
-    layout._recursively_apply(action, behavior=behavior)
+    layout.recursively_apply(action, behavior=behavior)
 
     return ak._util.wrap(output[0], behavior, highlevel)

src/awkward/operations/ak_fill_none.py

@@ -128,6 +128,6 @@ def action(layout, depth, depth_context, **kwargs):
                 return maybe_fillna(layout)
 
     depth_context = {"posaxis": axis}
-    out = arraylayout._recursively_apply(action, behavior, depth_context=depth_context)
+    out = arraylayout.recursively_apply(action, behavior, depth_context=depth_context)
 
     return ak._util.wrap(out, behavior, highlevel)

src/awkward/operations/ak_firsts.py

@@ -94,7 +94,7 @@ def action(layout, depth, depth_context, **kwargs):
             depth_context["posaxis"] = posaxis
 
         depth_context = {"posaxis": posaxis}
-        out = layout._recursively_apply(
+        out = layout.recursively_apply(
             action, behavior, depth_context, numpy_to_regular=True
         )
 

src/awkward/operations/ak_from_arrow.py

@@ -71,6 +71,6 @@ def remove_revertable(layout, **kwargs):
         if hasattr(layout, "__pyarrow_original"):
             del layout.__pyarrow_original
 
-    out._recursively_apply(remove_revertable)
+    out.recursively_apply(remove_revertable)
 
     return ak._util.wrap(out, behavior, highlevel)