Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad error message for decimal type #1870

Closed
martindurant opened this issue Nov 9, 2022 · 1 comment · Fixed by #1871
Closed

Bad error message for decimal type #1870

martindurant opened this issue Nov 9, 2022 · 1 comment · Fixed by #1871
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged

Comments

@martindurant
Copy link
Contributor

Version of Awkward Array

main

Description and code to reproduce

If you attempt to load a parquet file containing decimal columns, you get a ValueError, which is expected, but the message is:

"Arrow arrays containing pickled Python objects can't be converted into Awkward Arrays"

which looks like it's been copied from somewhere else.

https://github.com/scikit-hep/awkward/blob/main/src/awkward/_connect/pyarrow.py#L476
@martindurant martindurant added the bug (unverified) The problem described would be a bug, but needs to be triaged label Nov 9, 2022
@agoose77 agoose77 mentioned this issue Nov 9, 2022
Merged
@jpivarski
Copy link
Member

Thanks! That's a bad copy-paste from the pyarrow.lib.PyExtensionType case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set appropriate error message for decimal types in arrow scikit-hep/awkward
2 participants
@jpivarski @martindurant