Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set appropriate error message for decimal types in arrow #1871

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Nov 9, 2022

Fixes #1870


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-fix-from-arrow-error/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1871 (7801f58) into main (21c81e1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/pyarrow.py 88.46% <ø> (ø)
src/awkward/contents/indexedarray.py 76.60% <0.00%> (-0.19%) ⬇️
src/awkward/contents/recordarray.py 83.87% <0.00%> (-0.19%) ⬇️
src/awkward/_util.py 82.42% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.90% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making it a little more specific, so users know what to look for.

src/awkward/_connect/pyarrow.py Outdated Show resolved Hide resolved
src/awkward/_connect/pyarrow.py Outdated Show resolved Hide resolved
@jpivarski jpivarski enabled auto-merge (squash) November 9, 2022 19:24
@jpivarski jpivarski merged commit 17e674a into main Nov 9, 2022
@jpivarski jpivarski deleted the agoose77/fix-from-arrow-error branch November 9, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad error message for decimal type
2 participants