Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type_to_form returns non-JSON string in case of error #1932

Closed
agoose77 opened this issue Dec 1, 2022 · 3 comments · Fixed by #1960
Closed

type_to_form returns non-JSON string in case of error #1932

agoose77 opened this issue Dec 1, 2022 · 3 comments · Fixed by #1960
Assignees
Labels
bug The problem described is something that must be fixed

Comments

@agoose77
Copy link
Collaborator

agoose77 commented Dec 1, 2022

Version of Awkward Array

main

Description and code to reproduce

When using the RDataFrame integration, users attempting to work with unsupported column types see a cryptic error message. This occurs because type_to_form returns the string "unsupported type" for unsupported types, which then triggers an exception when Awkward attempts to call json.loads on the generated form.

Could we use std::variant here to catch the error case?

@agoose77 agoose77 added the bug The problem described is something that must be fixed label Dec 1, 2022
@agoose77
Copy link
Collaborator Author

agoose77 commented Dec 1, 2022

@jpivarski is this next-release? It's a new feature, with a hard-to-decode error message for unsupported use, so I'm 50-50 on it

@jpivarski
Copy link
Member

No, this issue is not about changing the API of the RDataFrame bridge, it's about fixing a bug.

The touchstone is, "Could someone's workflow start to depend on this, and then they'd have to adjust when we fix it?" I think it's pretty clearly "no" in this case.

@agoose77
Copy link
Collaborator Author

agoose77 commented Dec 1, 2022

🥳 less work! I'm all about the principle of least action.

For clarity; I was trying to gauge our pain threshold for the first release.

@ianna ianna linked a pull request Dec 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The problem described is something that must be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants