Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown type column #1960

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Dec 6, 2022


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/ianna-1932-type_to_form-returns-non-json-string-in-case-of-error/ once Read the Docs has finished building 🔨

@ianna ianna linked an issue Dec 6, 2022 that may be closed by this pull request
@ianna ianna marked this pull request as draft December 6, 2022 10:52
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1960 (e7eb79a) into main (f72ca9c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)

@ianna ianna marked this pull request as ready for review December 6, 2022 15:40
@ianna ianna requested a review from jpivarski December 6, 2022 15:42
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good: it fixes the observed error. Is there any other non-valid value that form_str can take? Is it true that any other value it can take is JSON and represents a real Form that from_buffers can either use or will fail with an appropriate error message there?

(This is just a question for follow-up work. This PR is an improvement in itself and I'll be merging it now. Thanks!!!)

@jpivarski jpivarski merged commit 2f04919 into main Dec 6, 2022
@jpivarski jpivarski deleted the ianna/1932-type_to_form-returns-non-json-string-in-case-of-error branch December 6, 2022 16:34
@ianna
Copy link
Collaborator Author

ianna commented Dec 7, 2022

This is good: it fixes the observed error. Is there any other non-valid value that form_str can take? Is it true that any other value it can take is JSON and represents a real Form that from_buffers can either use or will fail with an appropriate error message there?

(This is just a question for follow-up work. This PR is an improvement in itself and I'll be merging it now. Thanks!!!)

Yes, any other value returned by type_to_form and passed here is a valid JSON and represents a Form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type_to_form returns non-JSON string in case of error
2 participants