Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: 'simplify_uniontype' only in UnionArray #1130

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Nov 3, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1130 (6c19830) into main (0b0fb3f) will increase coverage by 2.10%.
The diff coverage is 86.97%.

Impacted Files Coverage Δ
src/awkward/_v2/forms/bitmaskedform.py 67.94% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py 69.01% <ø> (ø)
src/awkward/_v2/forms/indexedform.py 72.00% <ø> (+8.84%) ⬆️
src/awkward/_v2/forms/unmaskedform.py 69.49% <ø> (ø)
src/awkward/_v2/operations/convert/to_arrow.py 80.00% <ø> (+37.14%) ⬆️
src/awkward/_v2/types/numpytype.py 91.80% <ø> (ø)
src/awkward/_v2/forms/indexedoptionform.py 69.56% <50.00%> (-1.21%) ⬇️
src/awkward/_v2/contents/emptyarray.py 75.00% <59.09%> (+2.61%) ⬆️
src/awkward/_v2/contents/bitmaskedarray.py 63.27% <80.00%> (+3.39%) ⬆️
src/awkward/_v2/contents/unmaskedarray.py 62.85% <80.00%> (+0.63%) ⬆️
... and 23 more

@jpivarski
Copy link
Member

So far, this removes simplify_uniontype, but it doesn't move it into UnionArray.

@ioanaif
Copy link
Collaborator Author

ioanaif commented Nov 3, 2021

So far, this removes simplify_uniontype, but it doesn't move it into UnionArray.

It was already in UnionArray, so I just removed it from content.

@ioanaif ioanaif changed the title C++ refactoring: Move 'simplify_uniontype' C++ refactoring: 'simplify_uniontype' only in UnionArray Nov 3, 2021
@jpivarski
Copy link
Member

Okay, so is this PR done?

@ioanaif
Copy link
Collaborator Author

ioanaif commented Nov 3, 2021

Yes. All done with this PR. Will open new ones for the other tickets starting with num

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jpivarski jpivarski merged commit 13d7790 into main Nov 3, 2021
@jpivarski jpivarski deleted the ioanaif/move-simplify-union branch November 3, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants