Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: utility methods for high-level functions in v2. #1132

Merged
merged 16 commits into from
Nov 4, 2021

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski marked this pull request as draft November 3, 2021 15:47
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1132 (c2e03bb) into main (0b0fb3f) will increase coverage by 0.56%.
The diff coverage is 63.49%.

Impacted Files Coverage Δ
src/awkward/_v2/behaviors/string.py 100.00% <ø> (ø)
src/awkward/_v2/forms/bitmaskedform.py 67.94% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py 69.01% <ø> (ø)
src/awkward/_v2/forms/indexedform.py 72.00% <ø> (+8.84%) ⬆️
src/awkward/_v2/forms/unmaskedform.py 69.49% <ø> (ø)
src/awkward/_v2/highlevel.py 41.37% <ø> (+6.26%) ⬆️
.../awkward/_v2/operations/convert/ak_from_buffers.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_cupy.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_iter.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_jax.py 80.00% <0.00%> (ø)
... and 121 more

@jpivarski jpivarski linked an issue Nov 3, 2021 that may be closed by this pull request
@jpivarski jpivarski marked this pull request as ready for review November 4, 2021 16:49
@jpivarski
Copy link
Member Author

recursively_apply and broadcast_and_apply haven't been fully tested, but that will come when we reintroduce all the high-level functions. Whatever bugs are left are corner-cases. (It's translated from old code that worked and the basic cases work in the new code.)

So I'll merge this as soon as the tests pass, and then move on to to/from_buffers.

@jpivarski jpivarski enabled auto-merge (squash) November 4, 2021 16:57
@jpivarski jpivarski merged commit da9f384 into main Nov 4, 2021
@jpivarski jpivarski deleted the jpivarski/utility-methods-for-highlevel-functions branch November 4, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add axis=None functionality to ak.to/from_regular
1 participant