Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: UnionArray argsort and sort and enable tests #1141

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Nov 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1141 (b1bb82d) into main (0b0fb3f) will increase coverage by 0.90%.
The diff coverage is 66.21%.

Impacted Files Coverage Δ
src/awkward/_v2/behaviors/string.py 100.00% <ø> (ø)
src/awkward/_v2/forms/bitmaskedform.py 67.94% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py 69.01% <ø> (ø)
src/awkward/_v2/forms/indexedform.py 72.00% <ø> (+8.84%) ⬆️
src/awkward/_v2/forms/unmaskedform.py 69.49% <ø> (ø)
src/awkward/_v2/highlevel.py 41.37% <ø> (+6.26%) ⬆️
.../awkward/_v2/operations/convert/ak_from_buffers.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_cupy.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_iter.py 80.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_jax.py 80.00% <0.00%> (ø)
... and 126 more

@ianna ianna requested a review from jpivarski November 10, 2021 10:06
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably right: I wrote the first comment thinking it was for a different function—if I was wrong about that and there's nothing wrong with the code I pointed out, then this PR is 100% ok and if ready to be merged.

src/awkward/_v2/contents/unionarray.py Show resolved Hide resolved
src/awkward/_v2/contents/unionarray.py Show resolved Hide resolved
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - thanks for checking. This PR is a short one, I'm done with it.

src/awkward/_v2/contents/unionarray.py Show resolved Hide resolved
src/awkward/_v2/contents/unionarray.py Show resolved Hide resolved
@jpivarski jpivarski merged commit 934cb46 into main Nov 10, 2021
@jpivarski jpivarski deleted the ianna/unionarray-sort-fix branch November 10, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants