Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop all length information from TypeTracer, get all tests working again. #1184

Merged

Conversation

jpivarski
Copy link
Member

@ioanaif, @ianna, and @ctrl-stormy: this is requiring pervasive changes to the Python v2. PRs targeting the C++ will merge well with this, but if you're working on the Python, ask me about it in Slack.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1184 (e04c358) into main (9955401) will increase coverage by 1.50%.
The diff coverage is 83.23%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/pyarrow.py 83.33% <0.00%> (-0.48%) ⬇️
src/awkward/_v2/_reducers.py 96.48% <ø> (ø)
src/awkward/_v2/forms/recordform.py 66.46% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_to_numpy.py 100.00% <ø> (ø)
...c/awkward/_v2/operations/structure/ak_unflatten.py 80.00% <ø> (ø)
src/awkward/_v2/types/arraytype.py 80.76% <0.00%> (-0.72%) ⬇️
src/awkward/_v2/contents/unmaskedarray.py 56.27% <51.72%> (+0.82%) ⬆️
src/awkward/_v2/contents/indexedarray.py 59.75% <63.23%> (+0.44%) ⬆️
src/awkward/_v2/_typetracer.py 69.19% <63.58%> (-0.36%) ⬇️
src/awkward/_v2/contents/emptyarray.py 69.54% <74.19%> (+0.26%) ⬆️
... and 31 more

@jpivarski jpivarski marked this pull request as ready for review December 10, 2021 23:01
@jpivarski jpivarski enabled auto-merge (squash) December 10, 2021 23:02
@jpivarski jpivarski merged commit 0cfb4e4 into main Dec 10, 2021
@jpivarski jpivarski deleted the jpivarski/TypeTracerArray-length-should-be-completely-unknown branch December 10, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant