Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build wheels for ppc64le" #1239

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

jpivarski
Copy link
Member

Reverts #1224

@chrisburr I should have done a manual CD test, first. It didn't deploy: https://github.com/scikit-hep/awkward-1.0/actions/runs/1724731128

I'm reverting this to release 1.8.0rc3. We'll revisit it!

@jpivarski jpivarski merged commit 3800c83 into main Jan 20, 2022
@jpivarski jpivarski deleted the revert-1224-ppc64le-wheels branch January 20, 2022 19:38
@chrisburr
Copy link
Member

Ah I think it fails to test because numpy doesn't have ppc64le wheels (when I tested numpy was already installed so I didn't notice). It seems it's on the roadmap but I guess it'll have to wait for now unless you'd consider releasing untested ppc64le wheels?

@jpivarski
Copy link
Member Author

Okay, that explains it. If NumPy doesn't have PowerPC wheels, I don't think it helps much for Awkward to have PowerPC wheels because PowerPC users would have to compile something, anyway. (I'm assuming that it's at least as hard to compile NumPy as Awkward.) When they do, we can reinstate this, though.

@chrisburr
Copy link
Member

If NumPy doesn't have PowerPC wheels, I don't think it helps much for Awkward to have PowerPC wheels because PowerPC users would have to compile something, anyway.

Numpy is a fairly standard thing to find pre-installed so I think in most cases it's probably not an issue.

@jpivarski
Copy link
Member Author

I see—you're thinking it would come from the OS distribution's package manager. (I used to do that, but now I always get it from pip or conda. I don't trust my OS distribution's package manager for any Python packages.)

If it's reintroduced into the Awkward build, then GitHub Actions would have to compile NumPy, which isn't terrible, but it's a slow-down. It's not something we'd want to have happen in regular CI builds, though maybe a CD release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants